Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retries and retry removal for opsworks resources #9818

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Retries and retry removal for opsworks resources #9818

merged 1 commit into from
Aug 20, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_opsworks_stack: Final retry after timeout creating stack

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSOpsworksApplication"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSOpsworksApplication -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSOpsworksApplication
=== PAUSE TestAccAWSOpsworksApplication
=== CONT  TestAccAWSOpsworksApplication
--- PASS: TestAccAWSOpsworksApplication (99.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       100.393s

ake testacc TESTARGS="-run=TestAccAWSOpsworksRdsDbInstance"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSOpsworksRdsDbInstance -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSOpsworksRdsDbInstance
=== PAUSE TestAccAWSOpsworksRdsDbInstance
=== CONT  TestAccAWSOpsworksRdsDbInstance
--- PASS: TestAccAWSOpsworksRdsDbInstance (821.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       822.936s

--- PASS: TestAccAWSOpsworksStack_ImportBasic (22.43s)
--- PASS: TestAccAWSOpsworksStack_NoVpc (27.81s)
--- PASS: TestAccAWSOpsworksStack_Vpc (36.33s)
--- PASS: TestAccAWSOpsworksStack_NoVpcCreateTags (36.67s)
--- PASS: TestAccAWSOpsworksStack_NoVpcChangeServiceRoleForceNew (48.41s)

@ryndaniels ryndaniels requested a review from a team August 19, 2019 15:00
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/opsworks Issues and PRs that pertain to the opsworks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 19, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 19, 2019
@ryndaniels ryndaniels added this to the v2.25.0 milestone Aug 19, 2019
bflad
bflad approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSOpsworksStack_ImportBasic (23.08s)
--- PASS: TestAccAWSOpsworksStack_NoVpc (27.81s)
--- PASS: TestAccAWSOpsworksStack_NoVpcCreateTags (30.92s)
--- PASS: TestAccAWSOpsworksStack_Vpc (31.26s)
--- PASS: TestAccAWSOpsWorksStack_classic_endpoints (33.96s)
--- PASS: TestAccAWSOpsworksApplication (38.13s)
--- PASS: TestAccAWSOpsworksStack_NoVpcChangeServiceRoleForceNew (48.78s)
--- PASS: TestAccAWSOpsworksRdsDbInstance (743.39s)

aws/resource_aws_opsworks_application.go
if opserr, ok := cerr.(awserr.Error); ok {
// XXX: handle errors
log.Printf("[ERROR] OpsWorks error: %s message: %s", opserr.Code(), opserr.Message())
return resource.RetryableError(cerr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this resource.RetryableError() usage may have been legitimate because unlike the UpdateApp usage below, its retrying on AWS Go SDK errors. That said, it is probably okay to remove this and see if anything comes up where we discover the appropriate errors (if any) to actually retry on. The acceptance testing is not finding it currently.

@ryndaniels ryndaniels merged commit 234537f into master Aug 20, 2019
@ryndaniels ryndaniels deleted the rfd-retry-opsworkz branch August 20, 2019 12:09
@ghost
Copy link

ghost commented Aug 23, 2019

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/opsworks Issues and PRs that pertain to the opsworks service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad